ros2 / rclcpp

rclcpp (ROS Client Library for C++)
Apache License 2.0
536 stars 417 forks source link

Remove the set_deprecated signatures in any_subscription_callback. #2431

Closed clalancette closed 7 months ago

clalancette commented 7 months ago

These have been deprecated since April 2021, so it is safe to remove them now.

clalancette commented 7 months ago

CI:

christophebedard commented 7 months ago

Should this still be mentioned in the release notes?

clalancette commented 7 months ago

Should this still be mentioned in the release notes?

Yeah, that's a good idea. To be perfectly honest, I'm not sure what the user-visible effect of this is. Maybe @wjwwood can comment?

clalancette commented 7 months ago

I've opened up https://github.com/ros2/ros2_documentation/pull/4185 now, so I'm going to go ahead and merge this one.