search

ros2 / rclcpp

rclcpp (ROS Client Library for C++)
Apache License 2.0
513 stars 412 forks source link

Rule of five: implement move operators #2434

Closed Timple closed 4 months ago

Timple commented 4 months ago

I think @fujitatomoya had a point: https://github.com/ros2/rclcpp/pull/2425#discussion_r1491699756

So this is the alternative to: https://github.com/ros2/rclcpp/pull/2425

clalancette commented 4 months ago

@Timple It is preferred to update the old PR; that way the context of why we made the decision is preferred. In #2425 , you can update both the patch (by force-pushing), and the issue title (the edit button).

So with that in mind, I'm going to close this one.