search

ros2 / rclcpp

rclcpp (ROS Client Library for C++)
Apache License 2.0
513 stars 412 forks source link

:farmer: Flaky `TestTimersManager.check_one_timer_cancel_doesnt_affect_other_timers` failing in Windows #2436

Closed Crola1702 closed 2 months ago

Crola1702 commented 4 months ago

Bug report

Required Info:

Steps to reproduce issue

  1. Run a build in nightly_win_rep
  2. See TestTimersManager.check_one_timer_cancel_doesnt_affect_other_timers test failure

Expected behavior

Test should pass

Actual behavior

Test is failing

Additional information

Reference build: https://ci.ros2.org/view/nightly/job/nightly_win_rep/3273/#showFailuresLink

Test regressions:

Log output:

[ RUN      ] TestTimersManager.check_one_timer_cancel_doesnt_affect_other_timers
C:\ci\ws\src\ros2\rclcpp\rclcpp\test\rclcpp\test_timers_manager.cpp(405): error: Expected: (t1_runs + 5) < (t2_runs), actual: 10 vs 11

[  FAILED  ] TestTimersManager.check_one_timer_cancel_doesnt_affect_other_timers (16 ms)

Test was added 3 weeks ago, and it's failing flaky since then (https://github.com/ros2/rclcpp/pull/2375)

Crola1702 commented 2 months ago

This was fixed in: https://github.com/ros2/rclcpp/pull/2468