search

ros2 / rclcpp

rclcpp (ROS Client Library for C++)
Apache License 2.0
513 stars 412 forks source link

Switch from rcpputils::fs to std::filesystem #2438

Open christophebedard opened 4 months ago

christophebedard commented 4 months ago

Part of https://github.com/ros2/rcpputils/issues/164

I split the PR into two commits: internal changes and API changes.

christophebedard commented 4 months ago

I opened this as a draft because I'm not sure how to deal with the public API change for rclcpp::get_logging_directory(). I changed the return type from rcpputils::fs::path to std::filesystem::path because we can't have both, but they're functionally the same. I can't find any non-test calls to rclcpp::get_logging_directory() in the ROS 2 core.

The "cleanest" option is probably to deprecate the current function and create a new one with a different name, but that's unfortunate.