Modify rclcpp_action::GoalUUID hashing algorithm

ros2 / rclcpp

rclcpp (ROS Client Library for C++)

Apache License 2.0

513 stars 412 forks source link

Closed mauropasse closed 4 months ago

mauropasse commented 4 months ago

This PR does:

Add unit tests to detect collisions on the rclcpp_action::GoalUUID hashing algorithm.
Update the hashing algorithm to use the FNV-1a algorithm.

The unit tests were failing right away with the previous hashing algorithm, which produced the same output for different GoalUUIDs, quite often.

alsora commented 4 months ago

alsora commented 4 months ago

New CI run to verify whether test failures are caused by this PR

clalancette commented 4 months ago

We just made a change to CI to make it run things sequentially for the CI jobs, at least for now. So this should come out a lot more green now: