search

ros2 / rclcpp

rclcpp (ROS Client Library for C++)
Apache License 2.0
513 stars 412 forks source link

update rclcpp::Waitable API to use references and const #2467

Closed wjwwood closed 3 months ago

wjwwood commented 3 months ago

Splitting this off from https://github.com/ros2/rclcpp/pull/2420 and trying to make the deprecation cycle work.

wjwwood commented 3 months ago

Commit 7d9b19ba43bd36de82819cec1d10d5e07c3bfafa is the main change to the API, and the other commits are fixing the fallout.

mjcarroll commented 3 months ago
mjcarroll commented 3 months ago

New test failure on this one:

https://ci.ros2.org/job/ci_linux/20654/testReport/junit/ros2action.ros2action.test/test_cli/test_cli/

wjwwood commented 3 months ago

Need to rebase this after https://github.com/ros2/rclcpp/pull/2142 was merged.

wjwwood commented 3 months ago

New CI: