Flaky timer test fix - Githubissues

ros2 / rclcpp

rclcpp (ROS Client Library for C++)

Apache License 2.0

536 stars 417 forks source link

Flaky timer test fix #2469

Closed jmachowinski closed 6 months ago

jmachowinski commented 6 months ago

This fixed some issues reported in https://github.com/ros2/rcl/pull/1142

@clalancette, @mjcarroll , @fujitatomoya , @wjwwood

fujitatomoya commented 6 months ago

@jmachowinski thanks for the fix.

Regardless https://github.com/ros2/rcl/pull/1142, this is better to fix. i will start CI.

fujitatomoya commented 6 months ago

CI:

Linux
Linux-aarch64
Windows

jmachowinski commented 6 months ago

@fujitatomoya Yes, this patch just fixes the flakyness of the test. https://github.com/ros2/rcl/pull/1146 fixes the issues reported in 1142, can you also start the CI for this one ?

fujitatomoya commented 6 months ago

https://ci.ros2.org/job/ci_windows/21385/ is unrelated, i will go ahead to merge this.