Reduce overhead for inheriting from rclcpp::Executor when base functionality is not reused

ros2 / rclcpp

rclcpp (ROS Client Library for C++)

Apache License 2.0

514 stars 410 forks source link

Reduce overhead for inheriting from rclcpp::Executor when base functionality is not reused #2506

Closed wjwwood closed 2 months ago

wjwwood commented 2 months ago

refactor of "API Changes for Multihtreaded Events Executor": https://github.com/ros2/rclcpp/pull/2466

mergify[bot] commented 2 months ago

⚠️ The sha of the head commit of this PR conflicts with #2466. Mergify cannot evaluate rules on this PR. ⚠️

wjwwood commented 2 months ago

Tests are passing for me locally on rclcpp and rclcpp_lifecycle, running CI now:

Linux
Linux-aarch64
Windows

wjwwood commented 2 months ago

Well, CI passed finally, but Windows took way too long, so we're past the deadline. I'm going to ask for an exception for merging this one in tomorrow's meeting.

wjwwood commented 2 months ago

We got approval in the ROS 2 meeting, we'll announce this exception on discourse too. Merging it now. 🎉

ros-discourse commented 2 months ago

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/freeze-of-ros-2-base-packages-upcoming-branch-and-tutorial-party-for-jazzy-jalisco/37191/2