search

ros2 / rclcpp

rclcpp (ROS Client Library for C++)
Apache License 2.0
514 stars 410 forks source link

Executer regression fix #2509

Closed jmachowinski closed 2 months ago

jmachowinski commented 2 months ago

Fixes https://github.com/ros2/rclcpp/issues/2508

fujitatomoya commented 2 months ago

CI:

jmachowinski commented 2 months ago

I looked further into this, as all the tests lid up. I pushed an updated version, can someone rerun the CI with this ?

@wjwwood @mjcarroll I noticed, that the spin_some_impl method did not act according to the documentation. It was not recollecting ready executables on every call. Is this intentional, or a bug ?

fujitatomoya commented 2 months ago

@jmachowinski sorry i missed this, here is new CI.

CI:

wjwwood commented 2 months ago

Closing in favor of https://github.com/ros2/rclcpp/pull/2517, but we can reopen this one if needed.