Fixup Executor::spin_all() regression fix

ros2 / rclcpp

rclcpp (ROS Client Library for C++)

Apache License 2.0

514 stars 410 forks source link

Fixup Executor::spin_all() regression fix #2517

Closed wjwwood closed 2 months ago

wjwwood commented 2 months ago

This is a follow up of https://github.com/ros2/rclcpp/pull/2509 which addresses https://github.com/ros2/rclcpp/issues/2508.

wjwwood commented 2 months ago

CI:

Linux (updated after job got canceled)
Linux-aarch64 (known issues with mimic)
Windows (restarted after the job hung)

wjwwood commented 2 months ago

I added a comment in 8587653, so if the Rpr job comes back green I'll merge without new CI, since it was just a comment and Rpr checks style and linting.

wjwwood commented 2 months ago

I will then follow up with a jazzy backport.

wjwwood commented 2 months ago

@mergifyio backport jazzy

mergify[bot] commented 2 months ago

backport jazzy

✅ Backports have been created

* [#2521 Fixup Executor::spin_all() regression fix (backport #2517)](https://github.com/ros2/rclcpp/pull/2521) has been created for branch `jazzy`