search

ros2 / rclcpp

rclcpp (ROS Client Library for C++)
Apache License 2.0
514 stars 410 forks source link

add impl pointer for ExecutorOptions #2523

Closed wjwwood closed 1 month ago

wjwwood commented 1 month ago

Follow up of https://github.com/ros2/rclcpp/pull/2505#issuecomment-2059392440, we need this to potentially add more functionality to Jazzy post release, as well it gives us more flexibility to fix bugs in the future.

We already have this for the Executor, so this class is the only one that needs adjustment:

https://github.com/ros2/rclcpp/blob/f7185dc129c40388e66813c96f2ac5dbb73ffe00/rclcpp/include/rclcpp/executor.hpp#L597

wjwwood commented 1 month ago

CI:

wjwwood commented 1 month ago

Yup, I definitely did, but it should be fixed now, new CI:

clalancette commented 1 month ago

looks good to me, test failures are unrelated? (currently CI is unstable?)

Yeah, aarch64 is currently unstable. We can ignore those for now.

clalancette commented 1 month ago

@Mergifyio backport jazzy

mergify[bot] commented 1 month ago

backport jazzy

✅ Backports have been created

* [#2525 add impl pointer for ExecutorOptions (backport #2523)](https://github.com/ros2/rclcpp/pull/2525) has been created for branch `jazzy`