search

ros2 / rclcpp

rclcpp (ROS Client Library for C++)
Apache License 2.0
514 stars 410 forks source link

rclcpp::shutdown should not be called before LifecycleNode dtor. #2527

Closed fujitatomoya closed 1 month ago

fujitatomoya commented 1 month ago

address part of https://github.com/ros2/rclcpp/issues/2520

fujitatomoya commented 1 month ago

@clalancette can you take a look?

fujitatomoya commented 1 month ago

LifecyclePublisher is available in humble, so we need to backport this to all distro.

fujitatomoya commented 1 month ago

@mjcarroll @alsora i could use review for this. after i have a lgtm, i will start the CI.

fujitatomoya commented 1 month ago

CI:

fujitatomoya commented 1 month ago

aarch64 test failures are unrelated, https://ci.ros2.org/job/ci_linux-aarch64/15441/

fujitatomoya commented 1 month ago

@Mergifyio backport humble iron jazzy

mergify[bot] commented 1 month ago

backport humble iron jazzy

✅ Backports have been created

* [#2538 rclcpp::shutdown should not be called before LifecycleNode dtor. (backport #2527)](https://github.com/ros2/rclcpp/pull/2538) has been created for branch `humble` but encountered conflicts * [#2539 rclcpp::shutdown should not be called before LifecycleNode dtor. (backport #2527)](https://github.com/ros2/rclcpp/pull/2539) has been created for branch `iron` * [#2540 rclcpp::shutdown should not be called before LifecycleNode dtor. (backport #2527)](https://github.com/ros2/rclcpp/pull/2540) has been created for branch `jazzy`