ros2 / rclcpp

rclcpp (ROS Client Library for C++)
Apache License 2.0
514 stars 410 forks source link

call shutdown in LifecycleNode dtor to avoid leaving the device in unknown state (2nd) #2528

Closed fujitatomoya closed 1 month ago

fujitatomoya commented 1 month ago

address https://github.com/ros2/rclcpp/issues/2520

depends on https://github.com/ros2/rclcpp/pull/2527

fujitatomoya commented 1 month ago

we can backport this PR to jazzy, but we need to cherry-pick https://github.com/ros2/rclcpp/pull/2528/commits/2f451b67e0e2e5959d1fd32d6011c4f26cdbae28 to humble and iron.

fujitatomoya commented 1 month ago

this needs to be rebased to rolling since https://github.com/ros2/rclcpp/pull/2527 is merged.

fujitatomoya commented 1 month ago

CI:

fujitatomoya commented 1 month ago
fujitatomoya commented 1 month ago

@clalancette aarch64 detects many unrelated test failures, is this know issue?

[ RUN      ] TestNodeParameters.construct_destruct_rcl_errors
mimick: Initialization error: could not find definitions for vital function(s): 'abort' 'vfprintf'
-- run_test.py: return code -6
fujitatomoya commented 1 month ago

https://ci.ros2.org/job/ci_linux-aarch64/15479/ is known issue that can be addressed by https://github.com/ros2/Mimick/pull/36, so retrying CI again.

fujitatomoya commented 1 month ago
fujitatomoya commented 1 month ago

okay now it is green light, merging.

fujitatomoya commented 1 month ago

I am gonna do the backport,

fujitatomoya commented 1 month ago

@Mergifyio backport jazzy

mergify[bot] commented 1 month ago

backport jazzy

✅ Backports have been created

* [#2542 call shutdown in LifecycleNode dtor to avoid leaving the device in unknown state (2nd) (backport #2528)](https://github.com/ros2/rclcpp/pull/2542) has been created for branch `jazzy`