ros2 / rclcpp

rclcpp (ROS Client Library for C++)
Apache License 2.0
514 stars 410 forks source link

rclcpp::shutdown should not be called before LifecycleNode dtor. (backport #2527) #2538

Closed mergify[bot] closed 1 month ago

mergify[bot] commented 1 month ago

address part of https://github.com/ros2/rclcpp/issues/2520


This is an automatic backport of pull request #2527 done by Mergify.

mergify[bot] commented 1 month ago

Cherry-pick of 22df1d593a3e77917db8a7d7b20f57aee80d7e55 has failed:

On branch mergify/bp/humble/pr-2527
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 22df1d59.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
    both modified:   rclcpp_lifecycle/test/test_lifecycle_publisher.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

fujitatomoya commented 1 month ago

CI: