search

ros2 / rclcpp

rclcpp (ROS Client Library for C++)
Apache License 2.0
514 stars 410 forks source link

call shutdown in LifecycleNode dtor to avoid leaving the device in unknown state (2nd) (backport #2528) #2542

Closed mergify[bot] closed 3 weeks ago

mergify[bot] commented 1 month ago

address https://github.com/ros2/rclcpp/issues/2520

depends on https://github.com/ros2/rclcpp/pull/2527

This is an automatic backport of pull request #2528 done by Mergify.

fujitatomoya commented 1 month ago

CI:

Barry-Xu-2018 commented 1 month ago

The reason for the Linux-aarch64 failure is identical to issue #2528 (https://github.com/ros2/rclcpp/pull/2528#issuecomment-2136311334)

fujitatomoya commented 1 month ago

please do not merge this yet, i think we need to add https://github.com/ros2/rclcpp/pull/2545.

fujitatomoya commented 1 month ago

CI:

fujitatomoya commented 3 weeks ago

CI:

fujitatomoya commented 3 weeks ago

i think this is know issue of https://github.com/ros2/Mimick/pull/36, 

mimick: Initialization error: could not find definitions for vital function(s): 'abort' 'vfprintf'
-- run_test.py: return code -6
fujitatomoya commented 3 weeks ago

https://ci.ros2.org/job/ci_linux-aarch64/15552/#showFailuresLink is exactly same with https://ci.ros2.org/job/ci_linux-aarch64/15479/#showFailuresLink, known issue for jazzy CI.