search

ros2 / rclcpp

rclcpp (ROS Client Library for C++)
Apache License 2.0
536 stars 417 forks source link

lifecycle node dtor shutdown should be called only in primary state. #2544

Closed fujitatomoya closed 3 months ago

fujitatomoya commented 4 months ago

cherry-pick https://github.com/ros2/rclcpp/commit/a3caf1780dfe47f65fc702af3e6e03b1e6af2d33

fujitatomoya commented 4 months ago

CI:

fujitatomoya commented 4 months ago

please do not merge this yet, i think we need to add https://github.com/ros2/rclcpp/pull/2545.

fujitatomoya commented 4 months ago

CI:

fujitatomoya commented 3 months ago

windows failure is unrelated, https://ci.ros2.org/job/ci_windows/21919/