search

ros2 / rclcpp

rclcpp (ROS Client Library for C++)
Apache License 2.0
514 stars 410 forks source link

revert call shutdown in LifecycleNode destructor (Humble) #2560

Closed fujitatomoya closed 2 weeks ago

fujitatomoya commented 3 weeks ago

revert https://github.com/ros2/rclcpp/pull/2544 and https://github.com/ros2/rclcpp/pull/2491

fujitatomoya commented 3 weeks ago

CI (--packages-above-and-dependencies rclcpp_lifecycle):

fujitatomoya commented 3 weeks ago

hmmm, Linux-RHEL is not stable... i will give it a shot probably later.

12:03:13 java.nio.channels.ClosedChannelException
clalancette commented 3 weeks ago

hmmm, Linux-RHEL is not stable... i will give it a shot probably later.

It's already rebuilding as https://ci.ros2.org/job/ci_linux-rhel/735/ . You are just getting unlucky here for some reason. If it happens yet again, I'll ask the infrastructure team to look into it.

fujitatomoya commented 3 weeks ago

it is likely that i can see CI RHEL hung up with ros2cli ...

image

https://ci.ros2.org/job/ci_linux-rhel/733/console has the same situation.

fujitatomoya commented 3 weeks ago

CI (test --packages-above-and-dependencies rclcpp_lifecycle --packages-skip ros2cli)

fujitatomoya commented 3 weeks ago

CI (test --packages-above-and-dependencies rclcpp_lifecycle --packages-above-depth 1)

fujitatomoya commented 2 weeks ago

ignoring CI RHEL for humble for now because it is not stable, all other CIs are green, i will go ahead to merge this.