search

ros2 / rclcpp

rclcpp (ROS Client Library for C++)
Apache License 2.0
536 stars 417 forks source link

LifecycleNode bugfix and add test cases #2562

Closed fujitatomoya closed 2 weeks ago

fujitatomoya commented 3 months ago

follow up from https://github.com/ros2/rclcpp/issues/2520#issuecomment-2159092031

this can be backported to jazzy, iron and humble. (expecting conflict for iron and humble since type description is not available.)

fujitatomoya commented 3 months ago

@clalancette can you take a look? this is one of the follow-up, actually minor bug fix, debug print and test cases for LifecycleNode.

fujitatomoya commented 3 months ago

@clalancette @mjcarroll friendly ping, can you take a look when you have time?

fujitatomoya commented 3 months ago

either @clalancette or @mjcarroll can you please take a look before starting CI?

fujitatomoya commented 3 months ago

@alsora can you have a 2nd review for this?