Open Timple opened 7 months ago
Alright, we'll wait for those :slightly_smiling_face:
Subtle ping :slightly_smiling_face:
Sorry for subtle bump again, but Jade is coming up. And I'm afraid breaking changes won't be accepted anymore soon.
@clalancette @sloretz @ahcorde either of you, can you take a look at this? i think this is reasonable and more flexibility for rclpy client.
@Timple can you rebase this to rolling? almost 100 commits are behind.
@Timple can you rebase this to rolling? almost 100 commits are behind.
Done!
This pull request has been mentioned on ROS Discourse. There might be relevant details there:
So I missed the jazzy
release :crying_cat_face:
But this PR had some proper traction. Can we still get this in rolling?
If everybody is very busy doing release stuff for jazzy, I also fully understand. Then I'll apply some sort of exponential backoff to my pings :slightly_smiling_face:
@Timple sorry we missed this to jazzy. i will start the CI.
CC: @sloretz
It's green! 😄
@sloretz @clalancette friendly ping.
Joehoe :heart:
Just like rclcpp and ros1, allow action servers without execute callback.
Example like:
are typical cases where an action is succeeded based on information outside of the execute_cb.
It makes more sense to succeed these from outside the execute_cb in this case. And this would be in line with ros1 and rclcpp where this is possible.
I kept the
execute_callback
inargs
for backwards compatibility.