Add types to logging.py

ros2 / rclpy

rclpy (ROS Client Library for Python)

Apache License 2.0

268 stars 221 forks source link

Add types to logging.py #1226

Closed InvincibleRMC closed 4 months ago

InvincibleRMC commented 4 months ago

I was running mypy on my repository and it was complaining about get_logger() not being typed. So I added static typing to logging.py. Look at previous issues and pull requests. This change was already done similarly in #979 in response to issue #976. @clalancette mentioned that it should be split up into smaller pull requests.

sloretz commented 4 months ago

CI (repos file build: --packages-up-to rclpy test: --packages-select rclpy)

Linux
Linux-aarch64
Windows

InvincibleRMC commented 4 months ago

I removed the return from the initialize, shutdown, set_logger_level functions. It seems to me that those pybinded c++ functions return void. I also added other return types.

fujitatomoya commented 4 months ago

CI (repos file build: --packages-up-to rclpy test: --packages-select rclpy)

Linux

Linux-aarch64

Windows

CI(retry):

Linux
Linux-aarch64
Windows