search

ros2 / rclpy

rclpy (ROS Client Library for Python)
Apache License 2.0
268 stars 221 forks source link

Add types to logging_service.py #1227

Closed InvincibleRMC closed 4 months ago

InvincibleRMC commented 4 months ago

Added static typing to logging_service.py. This change was already done similarly in https://github.com/ros2/rclpy/pull/979 in response to issue https://github.com/ros2/rclpy/issues/976. Also fixes a spelling error of Invaild -> Invalid.

InvincibleRMC commented 4 months ago

Would the maintainers prefer a small PR per file like I have currently been doing? Or do you all have some other preference?

clalancette commented 4 months ago

Would the maintainers prefer a small PR per file like I have currently been doing? Or do you all have some other preference?

Small PRs are much preferred; they are much easier to review and run CI for. Thanks!

clalancette commented 4 months ago

CI:

InvincibleRMC commented 4 months ago

Any idea if my changes caused these regressions or is it an unrelated? @clalancette

fujitatomoya commented 4 months ago

it does not like related to the fix, CI restarted.

clalancette commented 4 months ago

The failed tests are unrelated here, so I'm going to go ahead and merge this in.