search

ros2 / rclpy

rclpy (ROS Client Library for Python)
Apache License 2.0
289 stars 224 forks source link

Support wait for message backport humble #1272

Closed fujitatomoya closed 3 months ago

fujitatomoya commented 5 months ago

This is the backport of the following PRs. (conflicts are resolved already)

backport is originally requested here, https://github.com/ros2/rclpy/issues/1179

note, this is purely adding a new method, this does not break API nor user application behavior.

fujitatomoya commented 5 months ago

CI:

Barry-Xu-2018 commented 5 months ago

LGTM

Timple commented 5 months ago

I added an option to specify the qos: https://github.com/ros2/rclpy/pull/1225/files

I would make this part of this backport.

fujitatomoya commented 5 months ago

rmw_connextdds_common build failed, i am not sure why.

clalancette commented 5 months ago

rmw_connextdds_common build failed, i am not sure why.

Ah, the build needs to specify humble (for the ROS_DISTRO) and jammy (for the UBUNTU_DISTRO)

fujitatomoya commented 5 months ago

@clalancette thanks, my bad... 😓

fujitatomoya commented 5 months ago

@Timple i will manage https://github.com/ros2/rclpy/pull/1225/files and retry CI.

fujitatomoya commented 5 months ago

CI:

fujitatomoya commented 5 months ago

https://ci.ros2.org/job/ci_windows/21567/ is unrelated.

@clalancette can we merge this?

fujitatomoya commented 3 months ago

This is actually the backport fix, since CI is green, i will go ahead to merge this.