Executor executes the tasks in FIFO order.

ros2 / rclpy

rclpy (ROS Client Library for Python)

Apache License 2.0

268 stars 221 forks source link

Executor executes the tasks in FIFO order. #1304

Closed fujitatomoya closed 5 days ago

fujitatomoya commented 1 week ago

address https://github.com/ros2/rclpy/issues/1303

fujitatomoya commented 1 week ago

@sloretz @Barry-Xu-2018 can you take a look at this?

i am not sure if we can backport this to jazzy since it changes behavior. i believe user application should not rely on the execution order, but we cannot say there is no application relies on the current behavior with released distro.

Barry-Xu-2018 commented 1 week ago

LGTM

fujitatomoya commented 5 days ago

CI:

Linux
Linux-aarch64
Linux-rhel
Windows

fujitatomoya commented 5 days ago

https://ci.ros2.org/job/ci_linux-rhel/834/#showFailuresLink is unrelated.

fujitatomoya commented 5 days ago

Note: we will not backport this since it changes the execution order in task queue. even though this fixes the order into FIFO which is expected order, this would be surprising behavior change for some user application.