Closed alberthli closed 3 months ago
LGTM. The rolling version already operates in this way.
Great. Are there any next steps before merging?
although this fixes static type checking, i guess we would want to proceed these changes from the upstream and then backport to downstream to avoid those fixes are scattered over distros. could you address those issues in rolling or pick up merged PR to be backported to released distros?
It looks like these are already fixed on the rolling
branch, so we are OK there.
In terms of backporting, I'm actually of the opinion that we should take this PR as-is. While it would be nice to cherry-pick changes from the upstream branches, I think it will be just as much work as doing them one-by-one here. And since @alberthli already has this one queued up and ready to go, I think we should just take it (though obviously we have to re-run CI here to make sure it is passing).
thanks, and im okay. sometimes backporting is not straight forward either so would require some adjustment.
CI looks good here, so going ahead and merging this one in. Thanks @alberthli !
Added
Optional
types to function declarations innode.py
where relevant on thehumble
branch. MissingOptional
types cause static type checking failures. Example: