search

ros2 / rclpy

rclpy (ROS Client Library for Python)
Apache License 2.0
308 stars 227 forks source link

Fixes spin_until_future_complete removing node it didn't add (backport #1316) #1342

Closed mergify[bot] closed 2 months ago

mergify[bot] commented 2 months ago

Closes https://github.com/ros2/rclpy/issues/1313 Current if spin_unitl_future_complete is called inside a nodes callback it removes the node from the executor This results in any subsiquent waitables to never be checked by the node since the node is no longer in the executor This aims to fix that by only removing the node from the executor if it wasn't already present

This is an automatic backport of pull request #1316 done by Mergify.

fujitatomoya commented 2 months ago

Pulls: ros2/rclpy#1342 Gist: https://gist.githubusercontent.com/fujitatomoya/6e1b7b073ae6f84c90ef05e26e980331/raw/705ad21a864c84ba8acd059e819896b4e4977049/ros2.repos BUILD args: --packages-above-and-dependencies rclpy TEST args: --packages-above rclpy ROS Distro: iron Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14485

sloretz commented 2 months ago

Pulls: https://github.com/ros2/rclpy/pull/1342 Gist: https://gist.githubusercontent.com/sloretz/c4576362e9ae8268e577051567afbb00/raw/705ad21a864c84ba8acd059e819896b4e4977049/ros2.repos BUILD args: --packages-up-to rclpy TEST args: --packages-select rclpy ROS Distro: iron Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14525

ahcorde commented 2 months ago

Linux-rhel warnings are unrelated.