Closed InvincibleRMC closed 3 weeks ago
Pulls: ros2/rclpy#1358 Gist: https://gist.githubusercontent.com/fujitatomoya/df5ddd92de46f7fbd7b4c45780230ecb/raw/d4a225117a62b661fa7b461ee574df76d2ccb99a/ros2.repos BUILD args: --packages-above-and-dependencies rclpy TEST args: --packages-above rclpy ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14629
Hmm ros2cli
is failing like #1349. I'm not really sure how that is possible since this code only changes unit tests in rclpy.
I heard that we found RHEL is unstable recently again, lets wait for windows then. lets keep this open until RHEL instability is fixed, i will get this back once that goes away to restart CI.
I heard that we found RHEL is unstable recently again, lets wait for windows then. lets keep this open until RHEL instability is fixed, i will get this back once that goes away to restart CI.
Ok please let me know when it gets fixed.
All known issues have now been fixed, so I'll run CI again.
Pulls: https://github.com/ros2/rclpy/pull/1358 Gist: https://gist.githubusercontent.com/clalancette/da6b7c58a4ac36fe3f2d3d70e23071f9/raw/d4a225117a62b661fa7b461ee574df76d2ccb99a/ros2.repos BUILD args: --packages-above-and-dependencies rclpy TEST args: --packages-above rclpy ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14644
So it does indeed look like RHEL is having issues with this PR. The nightly job didn't have any failures, while the CI job here did. So this needs to be looked into before we can merge this.
This is quite strange. How modifying test cases in rclpy causes only rhel ros2cli to fail.
This is quite strange. How modifying test cases in rclpy causes only rhel ros2cli to fail.
Agreed, I don't quite understand it myself, but there is a crash here in pyflakes
that doesn't seem to be in the nightlies:
Current thread 0x00007f1724fe2740 (most recent call first):
File "/usr/lib/python3.9/site-packages/pyflakes/checker.py", line 353 in __init__
File "/usr/lib/python3.9/site-packages/pyflakes/checker.py", line 915 in __init__
File "/usr/lib/python3.9/site-packages/flake8/plugins/pyflakes.py", line 94 in __init__
File "/usr/lib/python3.9/site-packages/flake8/checker.py", line 417 in run_check
File "/usr/lib/python3.9/site-packages/flake8/checker.py", line 493 in run_ast_checks
File "/usr/lib/python3.9/site-packages/flake8/checker.py", line 597 in run_checks
File "/usr/lib/python3.9/site-packages/flake8/checker.py", line 687 in _run_checks
File "/usr/lib64/python3.9/multiprocessing/pool.py", line 48 in mapstar
File "/usr/lib64/python3.9/multiprocessing/pool.py", line 125 in worker
File "/usr/lib64/python3.9/multiprocessing/process.py", line 108 in run
File "/usr/lib64/python3.9/multiprocessing/process.py", line 315 in _bootstrap
File "/usr/lib64/python3.9/multiprocessing/popen_fork.py", line 71 in _launch
File "/usr/lib64/python3.9/multiprocessing/popen_fork.py", line 19 in __init__
File "/usr/lib64/python3.9/multiprocessing/context.py", line 277 in _Popen
File "/usr/lib64/python3.9/multiprocessing/process.py", line 121 in start
File "/usr/lib64/python3.9/multiprocessing/pool.py", line 326 in _repopulate_pool_static
File "/usr/lib64/python3.9/multiprocessing/pool.py", line 303 in _repopulate_pool
File "/usr/lib64/python3.9/multiprocessing/pool.py", line 212 in __init__
File "/usr/lib64/python3.9/multiprocessing/context.py", line 119 in Pool
File "/usr/lib/python3.9/site-packages/flake8/checker.py", line 664 in _try_initialize_processpool
File "/usr/lib/python3.9/site-packages/flake8/checker.py", line 260 in run_parallel
File "/usr/lib/python3.9/site-packages/flake8/checker.py", line 309 in run
File "/usr/lib/python3.9/site-packages/flake8/main/application.py", line 271 in run_checks
File "/usr/lib/python3.9/site-packages/flake8/api/legacy.py", line 109 in check_files
File "/home/jenkins-agent/workspace/ci_linux-rhel/ws/install/ament_flake8/lib/python3.9/site-packages/ament_flake8/main.py", line 281 in generate_flake8_report
File "/home/jenkins-agent/workspace/ci_linux-rhel/ws/install/ament_flake8/lib/python3.9/site-packages/ament_flake8/main.py", line 88 in main_with_errors
File "/home/jenkins-agent/workspace/ci_linux-rhel/ws/src/ros2/ros2cli/ros2cli/test/test_flake8.py", line 22 in test_flake8
File "/usr/lib/python3.9/site-packages/_pytest/python.py", line 183 in pytest_pyfunc_call
File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
File "/usr/lib/python3.9/site-packages/_pytest/python.py", line 1641 in runtest
File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 162 in pytest_runtest_call
File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 255 in <lambda>
File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 311 in from_call
File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 254 in call_runtest_hook
File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 215 in call_and_report
File "/usr/lib/python3.9/site-packages/_pytest/runner.py", line 126 in runtestprotocol
File "/builddir/build/BUILDROOT/python-pytest-rerunfailures-9.1.1-3.el9.noarch/usr/lib/python3.9/site-packages/pytest_rerunfailures.py", line 240 in pytest_runtest_protocol
File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 348 in pytest_runtestloop
File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 323 in _main
File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 269 in wrap_session
File "/usr/lib/python3.9/site-packages/_pytest/main.py", line 316 in pytest_cmdline_main
File "/usr/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
File "/usr/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
File "/usr/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
File "/usr/lib/python3.9/site-packages/_pytest/config/__init__.py", line 162 in main
File "/usr/lib/python3.9/site-packages/_pytest/config/__init__.py", line 185 in console_main
File "/usr/lib/python3.9/site-packages/pytest/__main__.py", line 5 in <module>
File "/usr/lib64/python3.9/runpy.py", line 87 in _run_code
File "/usr/lib64/python3.9/runpy.py", line 197 in _run_module_as_main
Since this is the same error as https://github.com/ros2/ros2cli/issues/932 Should I try making a PR not on rclpy? To See if its typing in general or if typing on rclpy specifically is the problem? Unless you have a better idea for trouble shooting steps?
How modifying test cases in rclpy causes only rhel ros2cli to fail.
I just cannot tell... This is really weird...
the difference between CI and nightly jobs are,
CI_CMAKE_BUILD_TYPE
: CI is None
, nightly is Release
.-DPython3_EXECUTABLE=/usr/bin/python3
. that i tested CI job, this does not help it.we could ask some help for flake8 project with creating issue?
@mergifyio update
update
Pulls: https://github.com/ros2/rclpy/pull/1358 Gist: https://gist.githubusercontent.com/sloretz/81ef1fb38810dc80de05afeac3957c63/raw/ed65b256cf0cf0b945f9c10f001041eb86752447/ros2.repos BUILD args: --packages-up-to rclpy TEST args: --packages-select rclpy ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14739
Thank you for the PR!
This adds
None
type annotation to functions which take no inputs and return nothing. I understand this is a big PR and if it is too big I will split it up into smaller ones.