search

ros2 / rclpy

rclpy (ROS Client Library for Python)
Apache License 2.0
291 stars 224 forks source link

Add types to Action with rhel roscli fix #1361

Open InvincibleRMC opened 1 week ago

InvincibleRMC commented 1 week ago

Adds type to actions. A do over of #1349. I believe I have fixed the bug causing rhel roscli to fail.

InvincibleRMC commented 1 week ago

@fujitatomoya When you get a chance can you run rhel CI on this to see if the fix works?

fujitatomoya commented 1 week ago

Pulls: ros2/rclpy#1361 Gist: https://gist.githubusercontent.com/fujitatomoya/f6e3fb454459539dd4247706ad5abd87/raw/8844303445a5a3b903daea42dbae4862b475ffc4/ros2.repos BUILD args: --packages-above-and-dependencies rclpy TEST args: --packages-above rclpy ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14592

InvincibleRMC commented 1 week ago

I don't imagine the changes I made would cause the security failings in linux but, probably wise to run CI again to be sure?

fujitatomoya commented 1 week ago