search

ros2 / rcpputils

Apache License 2.0
32 stars 55 forks source link

[path] Declare the default assignment operator #156

Closed aprotyas closed 2 years ago

aprotyas commented 2 years ago

Satisfies -Wdeprecated-copy in Clang 13.

Closes #155.

Signed-off-by: Abrar Rahman Protyasha aprotyas@u.rochester.edu

aprotyas commented 2 years ago

@allsey87 I can't add you as a reviewer here, but FYI.

aprotyas commented 2 years ago

CI Repos file: https://gist.github.com/aprotyas/5d72bdea58ee5eff4b6f6fb556df85db Build args: --packages-up-to rcpputils Test args: --packages-select rcpputils Job: https://ci.ros2.org/job/ci_launcher/9598/

clalancette commented 2 years ago

I do think we should run a more comprehensive CI on this before merging, though. Since we are changing the header file, --packages-above rcpputils seems more appropriate.

fujitatomoya commented 2 years ago

that totally makes sense, CI restarted with build --packages-above-and-dependencies and test --packages-above

aprotyas commented 2 years ago

Both failing tests are reported as flaky upstream and seem to be unrelated.