validate the allocator before use.

[fujitatomoya]

minor patch to avoid possible segmentation fault in rcutils function scope.

related to https://github.com/ros2/rcl_logging/pull/116

[fujitatomoya]

CC: @clalancette @cottsay

[cottsay]

A few thoughts:

1. I don't think we should check this value in a function unless the function specifically uses it. If it just passes it through to another function, that other function should be responsible for checking it.
2. This is pretty nitpicky, but IIRC the convention is/was to check arguments for validity after checking for the presence of required arguments (i.e. null checks before value checks)
3. In general, I support more argument checking like this, but these are pretty low-level functions and they do get called pretty often. I don't think we'll see any noticeable performance impact, but we should be mindful.

[fujitatomoya]

note:

• although we do not have particular performance profiler, some places are considered as performance concern. if the check is during initialization and finalization, that should be no problem.
• assertion debug macro would be useful during the test to replace those checks.
• for performance sensitive execution paths, we can remove the check and add it to the doc section, allocate must not be null, otherwise unexpected behavior.
• if the allocator comes from implementation, there is no need to check that.

[fujitatomoya]

@ahcorde can you take a look at this?

[ahcorde]

• Linux
• Linux-aarch64
• Windows