search

ros2 / rcutils

Common C functions and data structures used in ROS 2
Apache License 2.0
56 stars 100 forks source link

Remove dependency on isatty() for Zephyr #458

Open drensber opened 5 months ago

drensber commented 5 months ago

The Zephyr OS doesn't have an isatty() function, so that dependency needs to be conditionally removed for Zephyr.

drensber commented 5 months ago

Sorry, this one looks messed up too. This all has to do with the confusing situation of micro-ROS being a fork of ROS, and my using that as a starting point (because GitHub won't let me make my own fork of the real ROS2 repo unless I delete my microROS fork).

drensber commented 5 months ago

I'd like to submit these changes, but I don't know if that's going to be possible until I can delete my GitHub fork that was originally based on micro-ROS/rcutils and create a new one that's based on ros2/rcutils. No matter what I do, my PR ends up being polluted with all sorts micro-ROS changes that I didn't intend to submit. Should I just close this one for now?

clalancette commented 5 months ago

I'd like to submit these changes, but I don't know if that's going to be possible until I can delete my GitHub fork that was originally based on micro-ROS/rcutils and create a new one that's based on ros2/rcutils

You shouldn't need to delete. Your fork can be called anything; I would suggest re-forking ros2/rcutils into your account as rcutils-upstream or something, and then making the PR from there. That said, yes, please close this until you get that setup properly.

drensber commented 5 months ago

I'd like to submit these changes, but I don't know if that's going to be possible until I can delete my GitHub fork that was originally based on micro-ROS/rcutils and create a new one that's based on ros2/rcutils

You shouldn't need to delete. Your fork can be called anything; I would suggest re-forking ros2/rcutils into your account as rcutils-upstream or something, and then making the PR from there. That said, yes, please close this until you get that setup properly.

No, GitHub doesn't seem to allow that... If I try to create a fork of ros2/rcutils, GitHub presents me with a message saying "No available destinations to fork this repository." Reading up on this, it seems that it really is an obscure limitation of GitHub https://stackoverflow.com/questions/12338240/how-can-i-fork-the-original-repo-when-ive-already-forked-a-different-fork

I'm sure that if I were especially adept with the rebase command, there'd be some way to clean all of the micro-ROS "pollution" out of the "rolling" branch on my fork of their fork, but I'm only marginally proficient with "git rebase". I honestly think that MicroROS should be its own separate repository, rather than a GitHub fork of yours, since they consider themselves to be a separate project. They could still keep in sync by pulling updates from yours.