Make dynamic prefault memory size configurable

ros2 / realtime_support

Minimal real-time testing utility for measuring jitter and latency.

61 stars 33 forks source link

Closed r7vme closed 4 years ago

r7vme commented 4 years ago

Add -d to set max dynamic memory prefaulting size. In old version it did preallocation till prefaulter vector reached the size of char array. Then vector reallocated (2x) in new memory and leaves old memory free, which causes char array to be put into this memory and does not cause page fault. In new implementation, vector already preallocated with requred size, which will prevent vector reallocations.
Fix issue with b,kb,mb,gb units parsing.
Fix in README actual stack size is 1MB (not 1024MB).

clalancette commented 4 years ago

CI (Linux only, since this code doesn't compile on Windows/macOS):

clalancette commented 4 years ago

Hm, this fails to build in CI, and locally for me. @r7vme , something needs to be fixed here.

r7vme commented 4 years ago

@clalancette PTAL

clalancette commented 4 years ago

Thanks. Another CI (Linux only, since this code doesn't compile on Windows/macOS):

r7vme commented 4 years ago

I believe this related to some Jenkins issues for aarch64 i see java tracebacks related to some networking issue

16:08:17 FATAL: command execution failed
16:08:17 java.nio.channels.ClosedChannelException

Can you please try to rerun it?

clalancette commented 4 years ago

@r7vme Yeah, there's a bit of a backlog on the buildfarm right now. I'll re-run it a bit later.

clalancette commented 4 years ago

@r7vme Looks like the linters aren't happy with this patch. Can you take a look?

r7vme commented 4 years ago

PTAL, please. Now both colcon build and colcon test are passed for me.

clalancette commented 4 years ago

CI (Linux only, since this code doesn't compile on Windows/macOS):

clalancette commented 4 years ago

All right, everything passed CI. Thanks for the contribution, merging.