Fix CMake lint test failure

ros2 / rmw

The ROS Middleware (rmw) Interface.

Apache License 2.0

95 stars 67 forks source link

Fix CMake lint test failure #303

Closed jacobperron closed 3 years ago

jacobperron commented 3 years ago

Line length should be <= 80 characters

Fixes https://build.ros2.org/view/Rdev/job/Rdev__rmw__ubuntu_focal_amd64/40/testReport

cottsay commented 3 years ago

Hold on a moment - the limit should be 140 columns, not 80. Something's not working right.

cottsay commented 3 years ago

The referenced job used ros-rolling-ament-cmake-lint-cmake-0.10.1-1focal.20210208.022417. Version 0.10.2 was tagged and built on Feb 12, and the build was sync'd to main on Feb 19th.

It appears this build failure was just a race with the ament_lint fixes merged on Feb 12th.

jacobperron commented 3 years ago

Yeah, you're right. I also had a stale workspace locally. Pulling the latest changes fixes the test failure for me. Sorry for the noise!