search

ros2 / rmw

The ROS Middleware (rmw) Interface.
Apache License 2.0
95 stars 67 forks source link

Add client/service QoS getters #314

Closed mauropasse closed 2 years ago

mauropasse commented 3 years ago

Blocked by: https://github.com/ros2/rmw_fastrtps/pull/560 https://github.com/ros2/rmw_implementation/pull/196

Signed-off-by: Mauro Passerino mpasserino@irobot.com

mauropasse commented 3 years ago

After some discussion (see https://github.com/ros2/rmw_connextdds/pull/67#discussion_r738447092) I updated all PRs to retrieve independently the QoS for Client request publisher / response subscription and Services request subscription / response publisher.

ivanpauno commented 3 years ago

@wjwwood do you have any thoughts on the proposed API? See discussion here.

ivanpauno commented 2 years ago

I have already discussed this with other members of the ROS 2 team and the proposed API looks fine. I will work on getting it merged tomorrow.

ivanpauno commented 2 years ago

CI https://github.com/ros2/rmw_implementation/pull/196#issuecomment-956442206