search

ros2 / rmw

The ROS Middleware (rmw) Interface.
Apache License 2.0
95 stars 69 forks source link

Reduce GID storage to 16 bytes. #345

Closed clalancette closed 1 year ago

clalancette commented 1 year ago

That is, the size of an RMW GID should be defined by the RMW layer and the RMW implementations should conform to it. With that said, 16 bytes is plenty (and happens to match the size of a GUID in DDS, which is also 16 bytes). So reduce this to 16 bytes.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

Note that this is a rehash of #328, but I think we have sufficient evidence now that this always should have been 16 bytes. This will also require a PR in rmw_dds_common, which is coming up next.

clalancette commented 1 year ago

Full CI:

clalancette commented 1 year ago

This is approved, and CI is clean. I'm going to go ahead and merge this (and the corresponding rmw_dds_common PR). Thanks for the review.