search

ros2 / rmw

The ROS Middleware (rmw) Interface.
Apache License 2.0
95 stars 67 forks source link

Improve handling of dynamic discovery - rmw changes (Extends #338) #349

Closed arjo129 closed 1 year ago

arjo129 commented 1 year ago

This PR extends #338 to support dynamic memory allocation.

wjwwood commented 1 year ago

As I pointed out a few in the review, there are some linter issues that need to be addressed too: https://build.ros2.org/job/Rpr__rmw__ubuntu_jammy_amd64/93/testReport/

wjwwood commented 1 year ago

Also we should consolidate this with https://github.com/ros2/rmw/pull/338 and address the feedback there as well.

wjwwood commented 1 year ago

Aside from a conversation about strncpy, I think all my review comments were addressed. I'm going to merge this with geoff's prs and continue there.