search

ros2 / rmw

The ROS Middleware (rmw) Interface.
Apache License 2.0
95 stars 67 forks source link

Initialize the NULL strucutre with static value. #378

Closed fujitatomoya closed 1 month ago

fujitatomoya commented 2 months ago

closes https://github.com/ros2/rmw/issues/377

fujitatomoya commented 2 months ago

@comicfans could you try this patch to see if it fixes your asan warning?

methylDragon commented 2 months ago

Makes sense to me, since the the struct is nested.

fujitatomoya commented 2 months ago

@clalancette sounds good to me, let me try to replace them all.

comicfans commented 2 months ago

@comicfans could you try this patch to see if it fixes your asan warning?

confirm this fix the problem

fujitatomoya commented 1 month ago

@clalancette can you take a look at this?

fujitatomoya commented 1 month ago

CI:

fujitatomoya commented 1 month ago

CI:

fujitatomoya commented 1 month ago

@clalancette all comments are resolved, lgtm?

fujitatomoya commented 1 month ago

RHEL is unstable, https://ci.ros2.org/job/ci_linux-rhel/1336/testReport/.