search

ros2 / rmw

The ROS Middleware (rmw) Interface.
Apache License 2.0
95 stars 67 forks source link

add rmw_get_default_xxx to return the structure with default values. #379

Open fujitatomoya opened 21 hours ago

fujitatomoya commented 21 hours ago

follow up for https://github.com/ros2/rmw/pull/378

fujitatomoya commented 21 hours ago

Pulls: ros2/rmw#379 Gist: https://gist.githubusercontent.com/fujitatomoya/65e549d1cfbf47cfcfd10df7e86bd521/raw/5a23d57d187e0028fde4536c468462cbe0f56501/ros2.repos BUILD args: --packages-above-and-dependencies rmw rcl rmw_implementation rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_connextdds_common rmw_cyclonedds_cpp TEST args: --packages-above rmw rcl rmw_implementation rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_connextdds_common rmw_cyclonedds_cpp ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14581

clalancette commented 17 hours ago

Just as an FYI, I'm not entirely sure we need these get_default APIs. I haven't looked at the RMW APIs, but we often have init-style APIs which tend to init them already; maybe we can lean more heavily on those? I'd need to look closer at the RMW APIs to see if that makes sense here.

fujitatomoya commented 1 hour ago

but we often have init-style APIs which tend to init them already; maybe we can lean more heavily on those?

i thought that too. but i think zero-init is also useful for data copy and finalization. so i do not think those are exclusive APIs.

fujitatomoya commented 1 hour ago

CI is failure to build, i think i misunderstood the usage of https://github.com/ros-tooling/ros-github-scripts?tab=readme-ov-file#ros-ci-for-pr

fujitatomoya commented 1 hour ago

Pulls: ros2/rmw#379, ros2/rcl#1186, ros2/rmw_implementation#241, ros2/rmw_fastrtps#778, ros2/rmw_connextdds#160, ros2/rmw_cyclonedds#513 Gist: https://gist.githubusercontent.com/fujitatomoya/18370bf1e0640d41a76698d03ad74dee/raw/7c320f893c82a71b0be07d942e42f59cb7e1df08/ros2.repos BUILD args: --packages-above-and-dependencies rmw rcl rmw_implementation rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_connextdds_common rmw_cyclonedds_cpp TEST args: --packages-above rmw rcl rmw_implementation rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_connextdds_common rmw_cyclonedds_cpp ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14583