search

ros2 / rmw_connextdds

ROS 2 RMW layer for RTI Connext DDS Professional and RTI Connext DDS Micro.
Apache License 2.0
48 stars 33 forks source link

Connext 7.0.0 #112

Closed BeatScherrer closed 1 year ago

BeatScherrer commented 1 year ago

Feature Description

Adjust package to suppor rti dds connext 7.0.0

Implementation Considerations

When compiling as is the following errors occur:

dds_api_ndds.cpp: In function ‘rmw_ret_t rmw_connextdds_return_samples(RMW_Connext_Subscriber*)’:
dds_api_ndds.cpp:818:7: error: invalid conversion from ‘DDS_Long’ {aka ‘int’} to ‘DDS_SampleInfoSeq*’ [-fpermissive]
dds_api_ndds.cpp:815:40: error: too many arguments to function ‘DDS_ReturnCode_t DDS_DataReader_return_loan_untypedI(DDS_DataReader*, void**, DDS_SampleInfoSeq*)’
mjcarroll commented 1 year ago

Since this would be bumping a major version of a large dependency, this would likely need to be part of the roadmap for the next version of ROS 2 (J-turtle).

I'm going to backlog this for now and we can consider this with the RTI folks as a potential feature for the next release.

CC: @asorbini

asorbini commented 1 year ago

Fixed by #121

BeatScherrer commented 1 year ago

Awesome! thanks for your efforts @asorbini