Export only rmw::rmw to downstream targets

ros2 / rmw_cyclonedds

ROS 2 RMW layer for Eclipse Cyclone DDS

Apache License 2.0

108 stars 89 forks source link

Export only rmw::rmw to downstream targets #360

Closed sloretz closed 2 years ago

sloretz commented 2 years ago

Required for ros2/rmw_implementation#201 which fixes a rolling CI job failure caused by ros2/rmw_cyclonedds#357

Since this is an rmw implementation, it's implementing the rmw API. I think rmw::rmw is the only target that needs to be marked PUBLIC. The rest downstream targets don't need to know about, and exporting them causes failures when the targets are from packages that don't get find_package()'d, notably with tracetools::tracetools..

sloretz commented 2 years ago

CI - build and test everything

Linux
Linux-aarch64
macOS
Windows

sloretz commented 2 years ago

CI LGTM because windows rosbag2 test failures are already in the nightly: https://ci.ros2.org/view/nightly/job/nightly_win_rel/2149/