search

ros2 / rmw_cyclonedds

ROS 2 RMW layer for Eclipse Cyclone DDS
Apache License 2.0
108 stars 89 forks source link

[foxy] Free with the same allocator in rmw_destroy_node (#355) #369

Closed jacobperron closed 2 years ago

jacobperron commented 2 years ago

Backport #355 to Foxy.

jacobperron commented 2 years ago

Is it okay that we have 6 failing checks? Seems like we should disable those if we are just going to ignore them.

jacobperron commented 2 years ago
eboasson commented 2 years ago

Is it okay that we have 6 failing checks? Seems like we should disable those if we are just going to ignore them.

I wouldn't consider it okay ... but I have never really known what it is that makes these tests work for some time, then start failing until someone tweaks "something" just so the pattern can repeat. It looks like some mismatch between versions in the CI scripting, but I am not sure. Surely there must be a way to have some level of CI integration for a stable release that doesn't require tweaking?

If I look at the Windows build it seems to be failing on installing Connext or something like that.

jacobperron commented 2 years ago

I don't have the bandwidth right now to investigate the github action failures, but following our process for other core ROS 2 packages, the FPr job is green and the results from ci.ros2.org (https://github.com/ros2/rmw_cyclonedds/pull/369#issuecomment-1027057259) look okay to me so I'm going to merge this.

I can return later to look at the github actions; it might be better to ultimately remove them since they are redundant with ci.ros2.org or are testing unsupported platforms (e.g. 18.04 and macOS).