Fix for shared memory transport tests

ros2 / rmw_cyclonedds

ROS 2 RMW layer for Eclipse Cyclone DDS

Apache License 2.0

112 stars 91 forks source link

Fix for shared memory transport tests #382

Closed dkroenke closed 2 years ago

dkroenke commented 2 years ago

Adding bug-fixes to rmw_cyclonedds:

additional checks for borrow_loaned_message_int to make sure that no nullptr is passed or when a message is already loaned
adding serialization in serdata_rmw_to_sample when is_request_header = false to work with server/client API

@eboasson @MatthiasKillat @sumanth-nirmal Would you take a look on this? ~~The PR is currently in Draft state because there is another issue with the node graph that needs investigation.~~

dkroenke commented 2 years ago

@eboasson @MatthiasKillat

Here the ROS 2 CI Run:

Linux
Linux-aarch64
Windows

dkroenke commented 2 years ago

Failing tests in Windows already exist on the nightly pipeline and a re not related to rmw_cyclonedds.

eboasson commented 2 years ago

@clalancette just checking: I believe 1 approval + green CI is sufficient for master and 2 approvals + green CI are required for release branches. I think it must be about freezing time so does that still hold?

clalancette commented 2 years ago

@clalancette just checking: I believe 1 approval + green CI is sufficient for master and 2 approvals + green CI are required for release branches. I think it must be about freezing time so does that still hold?

We're in freeze now (we'll send out a notice later today), and we haven't yet branched off for Humble. So right now, only fixes are allowed on the default/master branches. Since this qualifies as a fix, this is fine to merge now. But thanks for checking in!