Fix get_topic_name and handling long service names

[eboasson]

Determining whether a service is available relies on topic names, but the function to retrieve a topic name mishandled long names by accepting a truncated name when the 128-byte buffer passed in was too small instead of retrying with a larger buffer.

Cyclone DDS' underlying function always returns the actual length of the name and topic names can't change, and so there is no need to guess or loop.

Fixes #384

Signed-off-by: Erik Boasson eb@ilities.com

[eboasson]

CI:

• Linux
• Linux-aarch64
• Windows

[eboasson]

The latest commit should take care of it @pauldinh — I checked with your test with a range of lengths.

[eboasson]

@clalancette given that I had to fix my fix to fix essentially the same problem that needed fixing in the first place (😖) and the code base is frozen, I feel it is not quite right to merge it based on your original approval. Are you ok with me pressing merge on this one?

[clalancette]

@clalancette given that I had to fix my fix to fix essentially the same problem that needed fixing in the first place (confounded) and the code base is frozen, I feel it is not quite right to merge it based on your original approval. Are you ok with me pressing merge on this one?

This is a fix, so I'm fine with this going in. So I've re-approved it. That said, we should re-run CI on this before merging. Once that comes back successfully, it's fine to merge it.

[eboasson]

CI:

• Linux
• Linux-aarch64
• Windows

[eboasson]

Windows CI failures are unrelated