search

ros2 / rmw_cyclonedds

ROS 2 RMW layer for Eclipse Cyclone DDS
Apache License 2.0
108 stars 89 forks source link

[Humble] [fix] Add cstring header for memset #398

Closed homalozoa closed 1 year ago

homalozoa commented 2 years ago

Cherry-pick #393

clalancette commented 1 year ago

Did any CI for this get run? I know Humble is still pretty close to Rolling, but we generally still run CI.

ivanpauno commented 1 year ago

I trusted the Hpr__rmw_cyclonedds__ubuntu_jammy_amd64 job, which passed. I usually think that's fine for really small backports like this one, but let me know if you think I should also run full CI for this kind of changes.

clalancette commented 1 year ago

This one is borderline. It is a simple change, but without CI here we aren't testing on Windows. I guess since it is a backport, there's a lot less risk here.