search

ros2 / rmw_cyclonedds

ROS 2 RMW layer for Eclipse Cyclone DDS
Apache License 2.0
108 stars 89 forks source link

Improve error message when create_topic fails (backport #405) #408

Closed mergify[bot] closed 1 year ago

mergify[bot] commented 1 year ago

This is an automatic backport of pull request #405 done by Mergify.

Mergify commands and options
More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport ` will backport this PR on `` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com
sloretz commented 1 year ago

CI (repos file build: --packages-up-to rmw_cyclonedds_cpp test_rmw_implementation test: --packages-select rmw_cyclonedds_cpp test_rmw_implementation)

sloretz commented 1 year ago

Windows CI without this PR to see if test failures are already present:

Build Status

sloretz commented 1 year ago

It seems likely that projectroot.test_subscription__rmw_cyclonedds_cpp is flakey on Foxy, but I don't have evidence. I'll close this backport rather than investigating more.

tfoote commented 1 year ago

Reopening this as a backport to foxy would be valuable.

eboasson commented 1 year ago

@tfoote, @sloretz there is just no way that this change can cause that failure — and I recall there being some flakey test: https://github.com/ros2/rmw_cyclonedds/issues/279. I think you can safely merge this.

tfoote commented 1 year ago

Rerunning CI to double check from last week

CI (repos file build: --packages-up-to rmw_cyclonedds_cpp test_rmw_implementation test: --packages-select rmw_cyclonedds_cpp test_rmw_implementation)