search

ros2 / rmw_cyclonedds

ROS 2 RMW layer for Eclipse Cyclone DDS
Apache License 2.0
108 stars 89 forks source link

Include topic names in error messages #409

Closed tfoote closed 1 year ago

tfoote commented 1 year ago

Feature request

Feature description

We added better error messages when topics are invalid in #405 but the topics aren't included in the error message. It would be great to include them.

Implementation considerations

The topic name can be passed into this function to be included inthe error strings.

https://github.com/ros2/rmw_cyclonedds/pull/405/files#diff-91f31a99b38624440900850fd2df4710f2ef46c140999f3e3b8b89393e48e202R1790

And the name passed in in the 4 places it's invoked:

https://github.com/ros2/rmw_cyclonedds/pull/405/files#diff-91f31a99b38624440900850fd2df4710f2ef46c140999f3e3b8b89393e48e202R2296

https://github.com/ros2/rmw_cyclonedds/pull/405/files#diff-91f31a99b38624440900850fd2df4710f2ef46c140999f3e3b8b89393e48e202R2806

https://github.com/ros2/rmw_cyclonedds/pull/405/files#diff-91f31a99b38624440900850fd2df4710f2ef46c140999f3e3b8b89393e48e202R4638

https://github.com/ros2/rmw_cyclonedds/pull/405/files#diff-91f31a99b38624440900850fd2df4710f2ef46c140999f3e3b8b89393e48e202R4647

tfoote commented 1 year ago

@Voldivh FYI

Voldivh commented 1 year ago

Hey @tfoote, take a look at the PR #410 and let me know about any comments.

clalancette commented 1 year ago

We completed this in #410, so closing this issue.