ros2 / rmw_cyclonedds

ROS 2 RMW layer for Eclipse Cyclone DDS
Apache License 2.0
112 stars 91 forks source link

Remove outdated hack for ament_lint #411

Closed tfoote closed 2 years ago

tfoote commented 2 years ago

This is causing CI to fail because the referenced patch has been merged and the branch deleted.

https://github.com/ament/ament_lint/pull/268

tfoote commented 2 years ago

Also added a necessary action-ros-ci upgrade for https://github.com/ros-tooling/action-ros-ci/pull/430

``` Run ros-tooling/action-ros-ci@0.0.19 Invoking "bash -c 'rosdep update' Invoking "bash -c 'curl --fail --silent --show-error --location 'https://raw.githubusercontent.com/ros2/ros2/foxy/ros2.repos' | vcs import --force --recursive src/' Invoking "bash -c 'curl --fail --silent --show-error --location 'https://raw.githubusercontent.com/ros2/rmw_cyclonedds/3be1c[9](https://github.com/ros2/rmw_cyclonedds/runs/8119818947?check_suite_focus=true#step:6:10)d21ccd98e8e93ff8788dbf93e93a331622/.github/resources/local.repos' | vcs import --force --recursive src/' Invoking "bash -c 'find "/Users/runner/work/rmw_cyclonedds/rmw_cyclonedds/ros_ws" -type d -and -name "rmw_cyclonedds" | xargs rm -rf' Invoking "bash -c 'vcs import --force --recursive src/ < package.repo' Invoking "bash -c 'diff --new-line-format="" --unchanged-line-format="" <(colcon list -p) <(colcon list --packages-up-to rmw_cyclonedds_cpp rmw_implementation -p) | xargs rm -rf' Invoking "bash -c 'DEBIAN_FRONTEND=noninteractive RTI_NC_LICENSE_ACCEPTED=yes rosdep install -r --from-paths src --ignore-src --rosdistro foxy -y || true' Error: Unable to process command '::add-path::/Users/runner/work/rmw_cyclonedds/rmw_cyclonedds/ros_ws/install/bin' successfully. Error: The `add-path` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ Invoking "bash -c 'colcon build --event-handlers console_cohesion+ --packages-up-to rmw_cyclonedds_cpp rmw_implementation --cmake-args --symlink-install' Invoking "bash -c 'colcon lcov-result --initial' Invoking "bash -c 'colcon test --event-handlers console_cohesion+ --pytest-with-coverage --return-code-on-test-failure --packages-select rmw_cyclonedds_cpp rmw_implementation ' Error: The process '/bin/bash' failed with exit code 1 ```
tfoote commented 2 years ago

Replaced by #414