search

ros2 / rmw_cyclonedds

ROS 2 RMW layer for Eclipse Cyclone DDS
Apache License 2.0
108 stars 89 forks source link

Action based CI Broken for foxy pull requests #412

Closed tfoote closed 1 year ago

tfoote commented 1 year ago

Bug report

Required Info:

Steps to reproduce issue

Open a PR against the foxy branch with no or trivial changes.

Expected behavior

CI Passes

Actual behavior

CI Fails

Additional information

I found this when submitting: https://github.com/ros2/rmw_cyclonedds/pull/408

I've tried to fix two different CI issues in: https://github.com/ros2/rmw_cyclonedds/pull/411

christophebedard commented 1 year ago

Except for the Ubuntu-based jobs, the GitHub workflows have never really worked/passed on this repo.

tfoote commented 1 year ago

Looking at this as someone who's not usually contributing here, I've apparently wasted a lot of time trying to get them to work. Should we just remove them so others don't have the same problem?

christophebedard commented 1 year ago

That's probably a good idea.

cc @clalancette @jacobperron @sloretz @eboasson since you all seem to be the usual contributors.

clalancette commented 1 year ago

cc @clalancette @jacobperron @sloretz @eboasson since you all seem to be the usual contributors.

That's fine by me, they've never worked well here.

jacobperron commented 1 year ago

+1 for removing. I also sunk time in the past trying to get them to work without success (see https://github.com/ros2/rmw_cyclonedds/pull/372)

christophebedard commented 1 year ago

I can take care of this. #372 is already a good first step. Should we keep the Ubuntu jobs, or just remove everything?

clalancette commented 1 year ago

I can take care of this. #372 is already a good first step. Should we keep the Ubuntu jobs, or just remove everything?

I'm inclined to remove everything (we already have the Rpr jobs, and CI is required for everything anyway), but I don't feel strongly about it.

jacobperron commented 1 year ago

Since it doesn't appear anyone is maintaining the GitHub workflows, I would remove them entirely.

jacobperron commented 1 year ago

GitHub CI jobs removed in #414 for Rolling.

Here are backports for other distros: