search

ros2 / rmw_cyclonedds

ROS 2 RMW layer for Eclipse Cyclone DDS
Apache License 2.0
112 stars 91 forks source link

add NULL check before accessing object. #423

Closed fujitatomoya closed 2 years ago

fujitatomoya commented 2 years ago

argument check as rmw interface implementation. (this never happens if called from rcl, since rcl does this NULL check.)

Signed-off-by: Tomoya Fujita Tomoya.Fujita@sony.com

fujitatomoya commented 2 years ago

(came up in https://github.com/ros2/rclcpp/pull/2002.)

fujitatomoya commented 2 years ago

@eboasson thanks, yeah right! i was just thinking that it would be better to have these as in rmw implementation when we add the test for Listener APIs for rmw.

clalancette commented 2 years ago

CI:

clalancette commented 2 years ago

This needed a rebase to get the latest symbols, so I went and did that. Here's another CI: