search

ros2 / rmw_cyclonedds

ROS 2 RMW layer for Eclipse Cyclone DDS
Apache License 2.0
108 stars 89 forks source link

Implement inconsistent topic. #431

Closed clalancette closed 1 year ago

clalancette commented 1 year ago

Note that this is not hooked up inside of CycloneDDS, so this will never fire currently.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

Part of https://github.com/ros2/ros2/issues/1361

Depends on https://github.com/ros2/rmw/pull/339

ivanpauno commented 1 year ago

LGTM! It would be nice if we merge this after we have a rmw_implementation PR with tests and CI passing.

or maybe the tests could live in rcl

Crola1702 commented 1 year ago

It seems this PR somehow makes launch_testing_ros fail.

I ran 6 builds, building launch_testing_ros with and without this PR:

Building rclcpp and launch_testing_ros:

One more time:

Building launch_testing_ros only:

I used the following ros2.repos files:

FYI: