search

ros2 / rmw_cyclonedds

ROS 2 RMW layer for Eclipse Cyclone DDS
Apache License 2.0
108 stars 89 forks source link

Disable inconsistent topic events. #444

Closed clalancette closed 1 year ago

clalancette commented 1 year ago

These can't successfully be set on the entities right now, so just skip them.

Also make sure to check for errors when setting the status mask, which should help surface this kind of problem in the future.

I'll note that we are kind of lying here; we are telling the upper rcl/rclpy/rclpp layers that we support the INCOMPATIBLE_TYPE events, but then we are failing to register for it down below. But I think that is a reasonable compromise here.

@eboasson I'm especially interested on your take for this fix.

This replaces https://github.com/ros2/rmw_cyclonedds/pull/442 . @Crola1702 FYI

Crola1702 commented 1 year ago

Linux CI (only CycloneDDS): Build Status

clalancette commented 1 year ago

OK, thanks for the feedback! Here is full CI so we can get this in:

clalancette commented 1 year ago

The one test failures on Windows is a well-known flake. Going ahead and merging this, thanks for the reviews!